[
https://issues.apache.org/jira/browse/CASSANDRA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004427#comment-17004427
]
Andrew Prudhomme commented on CASSANDRA-15210:
----------------------------------------------
Thanks, I'm still learning this workflow.
Since it has been a while, I did a rebase and retest. It doesn't look like much
has changed.
||Branch||Tests||Local dtest||
|[trunk|https://github.com/apache/cassandra/compare/trunk...aprudhomme:15210-trunk]|[cci|https://circleci.com/workflow-run/11fbfb4e-fa3d-4dda-b08e-6850a539a335]|[pb|https://pastebin.com/dN6cpH9C]|
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...aprudhomme:15210-3.11]|[cci|https://circleci.com/workflow-run/c378d858-0ca1-4d11-aa95-50cabfef6897]|[pb|https://pastebin.com/U5Mqy4WY]|
> Streaming with CDC does not honor cdc_enabled
> ---------------------------------------------
>
> Key: CASSANDRA-15210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15210
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming, Feature/Change Data Capture
> Reporter: Andrew Prudhomme
> Assignee: Andrew Prudhomme
> Priority: Normal
>
> When SSTables are streamed for a CDC enabled table, the updates are processed
> through the write path to ensure they are made available through the commit
> log. However, currently only the CDC state of the table is checked. Since CDC
> is enabled at both the node and table level, a node with CDC disabled (with
> cdc_enabled: false) will unnecessarily send updates through the write path if
> CDC is enabled on the table. This seems like an oversight.
> I'd imagine the fix would be something like
>
> {code:java}
> - hasCDC = cfs.metadata.params.cdc;
> + hasCDC = cfs.metadata.params.cdc &&
> DatabaseDescriptor.isCDCEnabled();{code}
> in
> org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)
> org.apache.cassandra.streaming.StreamReceiveTask (3.11)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
