[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15460:
--------------------------------------
Reviewers: Alex Petrov, David Capwell, Yifan Cai, David Capwell (was: Alex
Petrov, David Capwell, Yifan Cai)
Alex Petrov, David Capwell, Yifan Cai, David Capwell (was: Alex
Petrov, Yifan Cai)
Status: Review In Progress (was: Patch Available)
LGTM, +1
Minor nit (aka feel free to ignore). If you modify startNativeTransport and
destroyNativeTransport to set this flag, then no change is needed in dtest.
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Doug Rohrer
> Assignee: Doug Rohrer
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
