[
https://issues.apache.org/jira/browse/CASSANDRA-15496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018426#comment-17018426
]
David Capwell commented on CASSANDRA-15496:
-------------------------------------------
The recent changes LGTM, but a small issue
{code}
$ grep -r 'long-testsome' *
build.xml: ant long-testsome -Dtest.name=org.apache.cassandra.cql3.ViewLongTest
-Dtest.methods=testConflictResolution
build.xml: <target name="long-testsome" depends="build-test"
description="Execute specific long unit tests" >
[davidcapwell ~/src/github/apache/cassandra] (trunk) $ grep -r 'long-test' *
build.xml: ant long-testsome -Dtest.name=org.apache.cassandra.cql3.ViewLongTest
-Dtest.methods=testConflictResolution
build.xml: <target name="long-testsome" depends="build-test"
description="Execute specific long unit tests" >
build.xml: <target name="long-test" depends="build-test" description="Execute
functional tests">
build.xml:
depends="eclipse-warnings,test,long-test,test-compression,stress-test,fqltool-test"
doc/source/development/testing.rst:Test that consume a significant amount of
time during execution can be found in the ``test/long`` directory and executed
as a regular JUnit test or standalone program. Except for the execution time,
there’s nothing really special about them. However, ant will execute tests
under ``test/long`` only when using the ``ant long-test`` target.
doc/source/development/testing.rst:Cassandra ships with a default `CircleCI
<https://circleci.com>`_ configuration, to enable running tests on your
branches, you need to go the CircleCI website, click "Login" and log in with
your github account. Then you need to give CircleCI permission to watch your
repositories. Once you have done that, you can optionally configure CircleCI to
run tests in parallel - click "Projects", then your github account and then
click the settings for the project. If you leave the parallelism at 1 for
Cassandra, only ``ant eclipse-warnings`` and ``ant test`` will be run. If you
up the parallelism to 4, it also runs ``ant long-test``, ``ant
test-compression`` and ``ant stress-test``
ide/idea/workspace.xml: <filter targetName="long-test" isVisible="true" />
{code}
since you are renaming that task, can you update those two lines in the docs?
Once that is done then +1 from me.
I have a question about this and java 8/11; currently this looks like it would
only be one but do you have plans to run both as one pipeline, or do you see
that as a second pipeline? What I see is that the test results will conflict
when we do that, and not sure if the copy will be overridden (wasn't able to
run since I only had dumb builds).
> Declarative Jenkins pipeline builds (and removing `ant test-all`)
> -----------------------------------------------------------------
>
> Key: CASSANDRA-15496
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15496
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
> Attachments: Screenshot 2020-01-17 at 21.14.52.png, Screenshot
> 2020-01-17 at 21.16.05.png, Screenshot 2020-01-17 at 21.16.47.png, Screenshot
> 2020-01-17 at 21.18.49.png
>
>
> *Declarative Jenkins pipeline*
> Currently all the jenkins build jobs are generated by the DSL job from the
> cassandra-builds repository.
> For a given branch, there are numerous builds: artifacts, unit tests, and
> dtests.
> Using a (declarative) {{Jenkinsfile}} in-tree these builds can be put
> together into per-branch pipelines.
> Per-branch pipelines will give a nicer UI (via blue ocean) and one place to
> look at test results for any branch and commit. From there we can post one
> complete test summary on commits back to the related jira ticket.
> ref:
> https://lists.apache.org/thread.html/rc8d5a55142ea3bfb742e3347b8ea924946796bad03a1e089c8fb9ee7%40%3Cdev.cassandra.apache.org%3E
> *Removing {{`ant test-all`}}*
> Currently the test-all target does nothing but execute the test target.
> This is because the test targets finishes with unit test failures.
> As these jenkins jobs are automated here:
> https://github.com/apache/cassandra-builds/blob/master/jenkins-dsl/cassandra_job_dsl_seed.groovy#L44
> ; it is easy enough to remove the "test-all" target, replacing it with
> separate jobs for 'stress-test', 'fqltool-test', and 'long-test'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
