[
https://issues.apache.org/jira/browse/CASSANDRA-15496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018551#comment-17018551
]
Michael Semb Wever edited comment on CASSANDRA-15496 at 1/18/20 11:04 AM:
--------------------------------------------------------------------------
I'm (not yet) comfortable going with the scripted pipeline approach (ie using
{{node}}).
While the declarative approach (using {{pipeline}}) is more opinionated, it
provides a better UI and is recommended by the Jenkins developers.
Reference: https://stackoverflow.com/a/44674335
I've taken your suggestion, and created just a function for the CopyArtifact
duplication. That [removes
120|https://github.com/thelastpickle/cassandra/commit/fff7b798c5409b10094fee57c18674f3f918f262]
lines of boilerplate, a big win, thanks! Beyond that improvements like
https://issues.jenkins-ci.org/browse/JENKINS-42224 and/or
https://issues.jenkins-ci.org/browse/JENKINS-49135 would look to be a direction
to take.
I've updated the patches above.
I've also undone the {{'s/long-test/test-long/`}} rename altogether. While only
in test code, making that change against all the branches seems a little
excessive.
was (Author: michaelsembwever):
I'm (not yet) comfortable going with the scripted pipeline approach (ie using
{{node}}).
While the declarative approach (using {{pipeline}}) is more opinionated, it
provides a better UI and is recommended by the Jenkins developers.
Reference: https://stackoverflow.com/a/44674335
I've taken your suggestion, and created just a function for the CopyArtifact
duplication. That [removes
120|https://github.com/thelastpickle/cassandra/commit/fff7b798c5409b10094fee57c18674f3f918f262]
lines of boilerplate, a big win, thanks! Beyond that improvements like
https://issues.jenkins-ci.org/browse/JENKINS-42224 and/or
https://issues.jenkins-ci.org/browse/JENKINS-49135 would look to be a direction
to take.
I've updated the patches above.
> Declarative Jenkins pipeline builds (and removing `ant test-all`)
> -----------------------------------------------------------------
>
> Key: CASSANDRA-15496
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15496
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
> Attachments: Screenshot 2020-01-17 at 21.14.52.png, Screenshot
> 2020-01-17 at 21.16.05.png, Screenshot 2020-01-17 at 21.16.47.png, Screenshot
> 2020-01-17 at 21.18.49.png
>
>
> *Declarative Jenkins pipeline*
> Currently all the jenkins build jobs are generated by the DSL job from the
> cassandra-builds repository.
> For a given branch, there are numerous builds: artifacts, unit tests, and
> dtests.
> Using a (declarative) {{Jenkinsfile}} in-tree these builds can be put
> together into per-branch pipelines.
> Per-branch pipelines will give a nicer UI (via blue ocean) and one place to
> look at test results for any branch and commit. From there we can post one
> complete test summary on commits back to the related jira ticket.
> ref:
> https://lists.apache.org/thread.html/rc8d5a55142ea3bfb742e3347b8ea924946796bad03a1e089c8fb9ee7%40%3Cdev.cassandra.apache.org%3E
> *Removing {{`ant test-all`}}*
> Currently the test-all target does nothing but execute the test target.
> This is because the test targets finishes with unit test failures.
> As these jenkins jobs are automated here:
> https://github.com/apache/cassandra-builds/blob/master/jenkins-dsl/cassandra_job_dsl_seed.groovy#L44
> ; it is easy enough to remove the "test-all" target, replacing it with
> separate jobs for 'stress-test', 'fqltool-test', and 'long-test'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
