[
https://issues.apache.org/jira/browse/CASSANDRA-15470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020623#comment-17020623
]
Dinesh Joshi edited comment on CASSANDRA-15470 at 1/21/20 11:55 PM:
--------------------------------------------------------------------
Thanks [~jrwest] for the review and [~mallika] for the patch. I went over it
and had some feedback. This
[branch|https://github.com/dineshjoshi/cassandra/commits/CASSANDRA-15470-review]
summarizes my proposed changes on top of your patch. If you think it is ok,
I'll go ahead and commit it.
was (Author: djoshi3):
Thanks [~jrwest] for the review and [~mallika] for the patch. I went over it
and had some feedback. This
[commit|https://github.com/apache/cassandra/commit/5232d829dbb3c086ad9eed569c6ea19829cd77ac]
summarizes my proposed changes on top of your patch. If you think it is ok,
I'll go ahead and commit it.
> Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB
> & Bytes
> -------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15470
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15470
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Jordan West
> Assignee: Mallika Kulkarni
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-rc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{DatabaseDescriptor}} has several functions that convert between user
> supplied sizes in KB/MB and bytes. These are implemented without much
> consistency and, while unlikely, several have the potential to overflow since
> validation on the input is missing. Meanwhile, some widen the number to a
> long correctly. Options include: widening in all places or simply doing
> better validation on start up — currently only the lower bound of the valid
> range is checked for many of these fields.
> List of Affected {{DatabaseDescriptor}} Methods:
> * {{getColumnIndexSize}}
> * {{getColumnIndexCacheSize}}
> * {{getBatchSizeWarnThreshold}}
> * {{getNativeTransportFrameBlockSize}}
> * {{getRepairSessionSpaceInMegabytes}}
> * {{getNativeTransportMaxFrameSize}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
