[
https://issues.apache.org/jira/browse/CASSANDRA-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020711#comment-17020711
]
Dinesh Joshi commented on CASSANDRA-15469:
------------------------------------------
[~jrwest], thanks for the patch. I have skimmed over the patch and I have some
concerns about making {{column_index_cache_size_in_kb}} a hotprop. I am mainly
concerned that this patch might cause races. For example,
- {{BigTableWriter::append}} method calls {{RowIndexEntry::create}} with
{{ColumnIndex::indexSamples}}. The hotprop change might race here and you may
end up with in memory index samples when you shouldn't.
- In {{ColumnIndex::addIndexBlock}} once we switch to byte-buffer mode,
increasing {{column_index_cache_size_in_kb}} will not switch back to the
{{ArrayList}} mode.
- {{ColumnIndex::reuseOrAllocateBuffer}} will not resize its buffer when
{{column_index_cache_size_in_kb}} is reset.
I haven't yet verified whether the hotprop might cause issues in the above.
Perhaps consider adding a test that will test the effect of changing the value
of {{column_index_cache_size_in_kb}} in some of these scenarios?
I will go through the patch more thoroughly and add more feedback if needed.
> IndexInfo/ColumnIndex Refactors & Cleanup
> -----------------------------------------
>
> Key: CASSANDRA-15469
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15469
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 4.0-beta
>
>
> Changes determined by audit of IndexInfo and ColumnIndex changes for
> Cassandra 4.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
