[
https://issues.apache.org/jira/browse/CASSANDRA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-4763:
----------------------------------------
Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams)
Brandon Williams, Brandon Williams (was: Alex Petrov)
Status: Review In Progress (was: Patch Available)
> SSTableLoader shouldn't get keyspace from path
> ----------------------------------------------
>
> Key: CASSANDRA-4763
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4763
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
> Affects Versions: 1.2.0 beta 1
> Reporter: Nick Bailey
> Assignee: Eduard Tudenhoefner
> Priority: Low
> Fix For: 4.0
>
>
> SSTableLoader currently gets the keyspace it is going to load to from the
> path of the directoy of sstables it is loading. This isn't really documented
> (or I didn't see it), but also isn't really a good way of doing it in general.
> {noformat}
> this.keyspace = directory.getParentFile().getName();
> {noformat}
> We should probably just let users pass the name in. If you are loading a
> snapshot the file names will have the keyspace which is slightly better but
> people manually creating their own sstables might not format them the same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
