[
https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025922#comment-17025922
]
Marcus Eriksson commented on CASSANDRA-15497:
---------------------------------------------
Nice! Minor comments;
* In {{AbstractCluster}}, the new {{version}} member - could we instead figure
this out by the version of the currently running instances? Or leave it for
later and just assert somewhere that we are not an {{UpgradeableCluster}} and
call it {{initialVersion}} instead?
* In {{AbstractCluster#bootstrap}} - maybe assert that we have
{{Feature.NETWORK}} and {{Feature.GOSSIP}} enabled to avoid hard-to-understand
errors?
* In {{AbstractCluster#bootstrap}} - in the {{if (null != prev)}} case - maybe
change the exception message to contain the instance number instead of
{{broadcastAddressAndPort}} which is bound to be the same for both.
* {{// TODO: make token allocation strategy configurable}} could be removed I
think?
* You could remove the {{repair}} step in the new test to make sure that
bootstrap streaming works
> Implement node bootstrap in in-JVM tests
> ----------------------------------------
>
> Key: CASSANDRA-15497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15497
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: High
>
> Currently, we do not have an ability to add nodes to the running in-jvm
> cluster, either by bootstrap or replacement process. We need to add an
> ability to add nodes in inactive state, start them up, and bootstrap to test
> streaming, range movements, and operations that occur during these processes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
