[ 
https://issues.apache.org/jira/browse/CASSANDRA-15505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027506#comment-17027506
 ] 

Alex Petrov commented on CASSANDRA-15505:
-----------------------------------------

Thank you for the review!

Committed to 2.2 with 
[b2f2c70e26a32253b0e58ee197c2f8abf01dd449|https://github.com/apache/cassandra/commit/b2f2c70e26a32253b0e58ee197c2f8abf01dd449],
 and merged up to 
[3.0|https://github.com/apache/cassandra/commit/a27092926b42a83ec0a1e6188677329737c5a3f4],
 
[3.11|https://github.com/apache/cassandra/commit/f09e1be19e5368bf18b4a81c9bed3bf0fc6643eb],
 and 
[trunk|https://github.com/apache/cassandra/commit/aa9326b17b4e49b470033b762070e5838b7bcd58]
 with minor modifications.

Most notably, 2.2 to 3.11 had a slightly different signature for 
{{deserializeMessage}} to expose {{partial}} int which is read from the buffer 
but is not a part of the message itself. Since it's not a public API, and we 
expose it only for convenience, this should be ok.

> Add message interceptors to in-jvm dtests
> -----------------------------------------
>
>                 Key: CASSANDRA-15505
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15505
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Test/dtest
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>            Priority: Normal
>              Labels: pull-request-available
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> Currently we only have means to filter messages in in-jvm tests. We need a 
> facility to intercept and modify the messages between nodes for testing 
> purposes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to