[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030027#comment-17030027
]
David Capwell commented on CASSANDRA-15429:
-------------------------------------------
Based off the patch I did the following greps
{code}
[davidcapwell ~/src/github/apache/cassandra] (trunk) $ grep -r 'new NodeProbe'
src/
src//java/org/apache/cassandra/tools/NodeTool.java: System.exit(new
NodeTool(new NodeProbeFactory()).execute(args));
src//java/org/apache/cassandra/tools/INodeProbeFactory.java: return new
NodeProbe(host, port);
src//java/org/apache/cassandra/tools/INodeProbeFactory.java: return new
NodeProbe(host, port, username, password);
[davidcapwell ~/src/github/apache/cassandra] (trunk) $ grep -r 'new NodeProbe'
test/
test//unit/org/apache/cassandra/tools/ClearSnapshotTest.java: probe =
new NodeProbe("127.0.0.1", JMX_PORT);
{code}
{code}
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ grep -r 'new
NodeProbe' src/
src//java/org/apache/cassandra/tools/NodeProbeFactory.java: return new
NodeProbe(host, port);
src//java/org/apache/cassandra/tools/NodeProbeFactory.java: return new
NodeProbe(host, port, username, password);
src//java/org/apache/cassandra/tools/NodeTool.java: System.exit(new
NodeTool(new NodeProbeFactory()).execute(args));
src//java/org/apache/cassandra/tools/NodeTool.java:
nodeClient = new NodeProbe(host, parseInt(port));
src//java/org/apache/cassandra/tools/NodeTool.java:
nodeClient = new NodeProbe(host, parseInt(port), username, password);
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ grep -r 'new
NodeProbe' test/
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $
{code}
After applying the patch
{code}
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ curl -o z.diff
https://github.com/ifesdjeen/cassandra/commit/bc4dc9826396e8e23ded8302fcef2fe39324205e.diff
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1593 0 1593 0 0 3034 0 --:--:-- --:--:-- --:--:-- 3028
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ patch -p1 <
z.diff
patching file src/java/org/apache/cassandra/tools/NodeTool.java
patching file
test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) grep -r 'new
NodeProbe' src/
src//java/org/apache/cassandra/tools/NodeProbeFactory.java: return new
NodeProbe(host, port);
src//java/org/apache/cassandra/tools/NodeProbeFactory.java: return new
NodeProbe(host, port, username, password);
src//java/org/apache/cassandra/tools/NodeTool.java: System.exit(new
NodeTool(new NodeProbeFactory()).execute(args));
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) grep -r 'new
NodeProbe' test/
{code}
> Support NodeTool for in-jvm dtest
> ---------------------------------
>
> Key: CASSANDRA-15429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This
> functionality is wanted in some tests, e.g. constructing an end-to-end test
> scenario that uses nodetool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
