[ 
https://issues.apache.org/jira/browse/CASSANDRA-15479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035832#comment-17035832
 ] 

Jon Haddad commented on CASSANDRA-15479:
----------------------------------------

I've reviewed the backup doc and overall it looks great.  I found a few things 
in my review:
 # Minor nit: Examples were predicated with explanations, which is good, but 
the expanation ended in a period.  I've updated them to colons. 
 # The explanation of incremental backups seemed to imply you would use them as 
an alternative to snapshots, which isn't how they're used.  They will typically 
be used as a means of incrementally updating a backup after a snapshot is 
taken.  
 # Due to the above, the doc should list snapshots before incremental repair, 
since incremental builds on snapshots.

I pushed up a branch here with those changes: 
[https://github.com/rustyrazorblade/cassandra/tree/jon/backups]

If you don't have any issues with the changes, I can squash and commit.  

 

> Backups - updated
> -----------------
>
>                 Key: CASSANDRA-15479
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15479
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Documentation/Website
>            Reporter: DeepakVohra
>            Assignee: DeepakVohra
>            Priority: Normal
>
> Added  Backups page.
> https://github.com/apache/cassandra/pull/408



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to