[
https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038523#comment-17038523
]
David Capwell commented on CASSANDRA-15564:
-------------------------------------------
ok, pushed a big refactor to the tests. What I saw was if you ran them ~50
times you will get a timeout (total run was close to the timeout window). This
also made it hard to add testing for the different parallel properties.
With the refactor we now have more test files (6 total), so in CI they will
each run concurrently (in circle ci) and have isolated timeout. This refactor
also enabled me to add the parallel flag as well, so also split the "fast"
tests from the "slow" (timeouts or node failures) tests.
The updated version now has 242 tests across 6 test files; below are the
timings I see for each test file (default timeout is 4 minutes for unit and 6
for dtest)
{code}
FullRepairCoordinatorFastTest: 43s
FullRepairCoordinatorSlowTest: 2m:51s
IncrementalRepairCoordinatorFastTest: 51s
IncrementalRepairCoordinatorSlowTest: 3m
PreviewRepairCoordinatorFastTest: 1m2s
PreviewRepairCoordinatorSlowTest: 3m
{code}
> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
> Key: CASSANDRA-15564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
> Project: Cassandra
> Issue Type: Sub-task
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated
> out.
> Currently the repair coordinator special cases the exit cases at each call
> site; this makes it so that errors can be inconsistent and there are cases
> where proper complete isn't done (proper notifications, and forgetting to
> update ActiveRepairService).
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
