[
https://issues.apache.org/jira/browse/CASSANDRA-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040319#comment-17040319
]
Dinesh Joshi commented on CASSANDRA-15591:
------------------------------------------
Not a full review, but quickly skimming the PR. Please add a unit test if it is
reasonably possible to do so. We have some tests for {{DatabaseDescriptor}} and
it would be good to add new ones as we touch existing code that doesn't have a
unit test. It just needs to cover your change.
> When we throw Invalid partitioner class add the cause to the exception and
> allow to log
> ---------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15591
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15591
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Tool/nodetool
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is spun off from CASSANDRA-13158
> When we have a exception creating the partition we should not mask the
> original error as it hides how to fix the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
