[ 
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040697#comment-17040697
 ] 

Andy Tolbert edited comment on CASSANDRA-14872 at 2/20/20 7:37 AM:
-------------------------------------------------------------------

Changes look great!  Played around with it a little bit and it's working well.  
I like that autocompletion works flawlessly for vtables :)

One thing that is interesting is that geomet is a required dependency.  Since 
it's apache licensed and seems pretty small that doesn't seem like much of a 
deal.  I think it could be made optional in the python driver (it's used for 
parsing DSE-specific geospatial types) so might be something worth pursuing on 
that end (but don't think it's needed as a prereq to this).


was (Author: andrew.tolbert):
Changes look great!  Played around with it a little bit and it's working well.  
I like that autocompletion works flawlessly for vtables :)

One thing that is interesting is that geomet is a required dependency.  Since 
it's apache licensed and seems pretty small that doesn't seem like much of a 
deal.  I think it could be made optional in the python driver (it's used for 
parsing DSE-specific geospatial types) so might be something worth pursuing on 
that end.

> Update to version of python driver and update cqlsh to use driver metadata 
> for virtual tables
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14872
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/cqlsh
>            Reporter: Andy Tolbert
>            Assignee: Dinesh Joshi
>            Priority: Normal
>             Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated 
> to parse virtual keyspace metadata by making queries to the 
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses 
> virtual keyspace metadata.   It would be good to update the bundled python 
> driver and simplify cqlsh code to utilize its capability to parse virtual 
> tables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to