[ 
https://issues.apache.org/jira/browse/CASSANDRA-15597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048330#comment-17048330
 ] 

Jeff commented on CASSANDRA-15597:
----------------------------------

Patch here: https://github.com/jefftt/cassandra/pull/new/15597-4.0

> Correct Visibility and Improve Safety of Methods in LatencyMetrics
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-15597
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15597
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Metrics
>            Reporter: Jordan West
>            Priority: Normal
>             Fix For: 4.0
>
>
> * add/removeChildren does not need to be public (and exposing addChildren is 
> unsafe since no lock is used). 
> * casting in the constructor is safer than casting each time in removeChildren



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to