[ https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050751#comment-17050751 ]
David Capwell edited comment on CASSANDRA-15564 at 3/4/20 3:52 AM: ------------------------------------------------------------------- Since the feedback looks close I created a rebased branch [here|https://github.com/dcapwell/cassandra/commits/bug/repairCoordinatorJmxConsistency-rebase]. The branch has 2 commits: rebase against trunk, and fix regression caused by rebasing (conflict with CASSANDRA-15553) [Circle CI with LOWER config|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency-rebase] was (Author: dcapwell): Since the feedback looks close I created a rebased branch [here|https://github.com/dcapwell/cassandra/commits/bug/repairCoordinatorJmxConsistency-rebase]. The branch has 2 commits: rebase against trunk, fix regression caused by rebasing (conflict with CASSANDRA-15553) [Circle CI with LOWER config|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency-rebase] > Refactor repair coordinator so errors are consistent > ---------------------------------------------------- > > Key: CASSANDRA-15564 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15564 > Project: Cassandra > Issue Type: Sub-task > Components: Consistency/Repair > Reporter: David Capwell > Assignee: David Capwell > Priority: Normal > Labels: pull-request-available > Time Spent: 11h 10m > Remaining Estimate: 0h > > This is to split the change in CASSANDRA-15399 so the refactor is isolated > out. > Currently the repair coordinator special cases the exit cases at each call > site; this makes it so that errors can be inconsistent and there are cases > where proper complete isn't done (proper notifications, and forgetting to > update ActiveRepairService). > [Circle > CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org