[
https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065303#comment-17065303
]
David Capwell edited comment on CASSANDRA-15651 at 3/24/20, 4:12 AM:
---------------------------------------------------------------------
Testing done (only on trunk)
{code}
$ curl
'https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist.diff'
| patch -p1
$ cd cassandra
# test no args
$
/Users/dcapwell/src/github/apache/cassandra-builds/build-scripts/cassandra-test.sh
...
+ case $1 in
/Users/davidcapwell/src/github/apache/cassandra-builds/build-scripts/cassandra-test.sh:
line 27: $1: unbound variable
{code}
[this|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist#diff-91876f5f158ec50dab9a70cc06c06922R27]
should be "${1:-}"; this happens because 'set -o nounset' is set (useful for
finding typos and missing args) (also need it
[here|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist#diff-91876f5f158ec50dab9a70cc06c06922R56]
for the same reasons, I normally turn into a variable and just reference that).
{code}
... stress-test
...
BUILD SUCCESSFUL
Total time: 8 seconds
{code}
{code}
... fqltool-test
...
BUILD SUCCESSFUL
Total time: 10 seconds
{code}
{code}
... test-burn
...
BUILD SUCCESSFUL
Total time: 4 seconds
{code}
{code}
... long-test
...
BUILD SUCCESSFUL
Total time: 3 seconds
{code}
For test-jvm-dtest-forking, test, and test-compression I didn't run to
completion since they take a long time single threaded.
Here is my run for test-cdc
{code}
... test-cdc
...
[junit-timeout] Testcase:
org.apache.cassandra.batchlog.BatchlogManagerTest-cdc: Caused an ERROR
[junit-timeout] Cannot locate
file:////Users/dcapwell/src/github/apache/cassandra-trunk/build/test/cassandra.cdc.yaml.
If this is a local file, please confirm you've provided file:/// as a URI
prefix.
[junit-timeout] org.apache.cassandra.exceptions.ConfigurationException: Cannot
locate
file:////Users/dcapwell/src/github/apache/cassandra-trunk/build/test/cassandra.cdc.yaml.
If this is a local file, please confirm you've provided file:/// as a URI
prefix.
[junit-timeout] at
org.apache.cassandra.config.YamlConfigurationLoader.getStorageConfigURL(YamlConfigurationLoader.java:85)
[junit-timeout] at
org.apache.cassandra.config.YamlConfigurationLoader.loadConfig(YamlConfigurationLoader.java:100)
[junit-timeout] at
org.apache.cassandra.OffsetAwareConfigurationLoader.loadConfig(OffsetAwareConfigurationLoader.java:55)
[junit-timeout] at
org.apache.cassandra.config.DatabaseDescriptor.loadConfig(DatabaseDescriptor.java:299)
[junit-timeout] at
org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:175)
[junit-timeout] at
org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:160)
[junit-timeout] at
org.apache.cassandra.batchlog.BatchlogManagerTest.defineSchema(BatchlogManagerTest.java:75)
...
{code}
so test-cdc creates these paths but testclasslist-cdc doesn't; testlist-cdc
looks to have a bug
{code}
<property name="cdc_yaml" value="${build.test.dir}/cassandra.cdc.yaml"/>
{code}
is defined, but doesn't actually concat it. I locally copied the concat over
and the tests seem to be passing now.
was (Author: dcapwell):
Testing done
{code}
$ curl
'https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist.diff'
| patch -p1
$ cd cassandra
# test no args
$
/Users/dcapwell/src/github/apache/cassandra-builds/build-scripts/cassandra-test.sh
...
+ case $1 in
/Users/davidcapwell/src/github/apache/cassandra-builds/build-scripts/cassandra-test.sh:
line 27: $1: unbound variable
{code}
[this|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist#diff-91876f5f158ec50dab9a70cc06c06922R27]
should be "${1:-}"; this happens because 'set -o nounset' is set (useful for
finding typos and missing args) (also need it
[here|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist#diff-91876f5f158ec50dab9a70cc06c06922R56]
for the same reasons, I normally turn into a variable and just reference that).
{code}
... stress-test
...
BUILD SUCCESSFUL
Total time: 8 seconds
{code}
{code}
... fqltool-test
...
BUILD SUCCESSFUL
Total time: 10 seconds
{code}
{code}
... test-burn
...
BUILD SUCCESSFUL
Total time: 4 seconds
{code}
{code}
... long-test
...
BUILD SUCCESSFUL
Total time: 3 seconds
{code}
For test-jvm-dtest-forking, test, and test-compression I didn't run to
completion since they take a long time single threaded.
Here is my run for test-cdc
{code}
... test-cdc
...
[junit-timeout] Testcase:
org.apache.cassandra.batchlog.BatchlogManagerTest-cdc: Caused an ERROR
[junit-timeout] Cannot locate
file:////Users/dcapwell/src/github/apache/cassandra-trunk/build/test/cassandra.cdc.yaml.
If this is a local file, please confirm you've provided file:/// as a URI
prefix.
[junit-timeout] org.apache.cassandra.exceptions.ConfigurationException: Cannot
locate
file:////Users/dcapwell/src/github/apache/cassandra-trunk/build/test/cassandra.cdc.yaml.
If this is a local file, please confirm you've provided file:/// as a URI
prefix.
[junit-timeout] at
org.apache.cassandra.config.YamlConfigurationLoader.getStorageConfigURL(YamlConfigurationLoader.java:85)
[junit-timeout] at
org.apache.cassandra.config.YamlConfigurationLoader.loadConfig(YamlConfigurationLoader.java:100)
[junit-timeout] at
org.apache.cassandra.OffsetAwareConfigurationLoader.loadConfig(OffsetAwareConfigurationLoader.java:55)
[junit-timeout] at
org.apache.cassandra.config.DatabaseDescriptor.loadConfig(DatabaseDescriptor.java:299)
[junit-timeout] at
org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:175)
[junit-timeout] at
org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:160)
[junit-timeout] at
org.apache.cassandra.batchlog.BatchlogManagerTest.defineSchema(BatchlogManagerTest.java:75)
...
{code}
so test-cdc creates these paths but testclasslist-cdc doesn't; testlist-cdc
looks to have a bug
{code}
<property name="cdc_yaml" value="${build.test.dir}/cassandra.cdc.yaml"/>
{code}
is defined, but doesn't actually concat it. I locally copied the concat over
and the tests seem to be passing now.
> Jenkins tests to use testclasslist where possible (like CircleCI)
> -----------------------------------------------------------------
>
> Key: CASSANDRA-15651
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15651
> Project: Cassandra
> Issue Type: Task
> Components: Build, Test/unit
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
>
> Following up on CASSANDRA-15639
> make all the jenkins test jobs run in the same manner.
> This standards the approach across test jobs and to CircleCI, and will make
> it easier to parallelise test runs later on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
