[
https://issues.apache.org/jira/browse/CASSANDRA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072296#comment-17072296
]
David Capwell commented on CASSANDRA-15631:
-------------------------------------------
moving to commits rather than diff so the links are stable
bq. Not sure which assert you were referring to since the code has changed
since your comment
[I believe it was
this|https://github.com/newkek/cassandra/commit/e10c0da352c8dc7c362f36fd081eb9970f9fd2d9#diff-1dd73505fd4b8d16fb40a4aebb68e5eeL251],
you comment that it is [now
here|https://github.com/newkek/cassandra/commit/e10c0da352c8dc7c362f36fd081eb9970f9fd2d9#diff-1dd73505fd4b8d16fb40a4aebb68e5eeR245].
LGTM.
bq. Latest run (#17) had a failure that didn't seem related to these changes,
and the test passed when I ran it locally.
Yeah, that test is flakey, CASSANDRA-15650 fixes it.
For the most part LGTM. I would +1 but I want to look closer at the Junit 5
thing, ill make sure to do this tomorrow.
> Add AssertJ test dependency
> ---------------------------
>
> Key: CASSANDRA-15631
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15631
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest, Test/unit
> Reporter: Kevin Gallardo
> Assignee: Kevin Gallardo
> Priority: Normal
> Fix For: 4.0-beta
>
>
> See
> [proposal|https://lists.apache.org/thread.html/rc562ec47578d0ae6f346ba9e3d7469c1cd3f8b521a72ddcb2accc47b%40%3Cdev.cassandra.apache.org%3E].
> The goal is to add [AssertJ|https://assertj.github.io/doc/] to the test
> framework to allow for more comprehensible and easier to write tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
