[ 
https://issues.apache.org/jira/browse/CASSANDRA-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075087#comment-17075087
 ] 

ZhaoYang commented on CASSANDRA-15657:
--------------------------------------

Thanks for the reply..

bq. IIRC the SSTable metadata only contains the beginning and ending tokens.

I didn't get it.. Do sstable-metadata and its beginning/ending tokens matter 
here?

bq. However, in the wrap around use-case you'd need to unwrap the ranges and do 
the check.  I don't think your check works in the wrap around case.

File sections are computed based on normalized ranges which are unwrapped and 
sections will never overlap. [~djoshi] did I miss anything?

> Improve zero-copy-streaming containment check by using file sections
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-15657
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15657
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Streaming and Messaging
>            Reporter: ZhaoYang
>            Assignee: ZhaoYang
>            Priority: Normal
>             Fix For: 4.0
>
>
> Currently zero copy streaming is only enabled for leveled-compaction strategy 
> and it checks if all keys in the sstables are included in the transferred 
> ranges.
> This is very inefficient. The containment check can be improved by checking 
> if transferred sections (the transferred file positions) cover entire sstable.
> I also enabled ZCS for all compaction strategies since the new containment 
> check is very fast..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to