[
https://issues.apache.org/jira/browse/CASSANDRA-15694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-15694:
------------------------------------------
Description:
There is a bug in the current code as if we are streaming entire SSTables via
CassandraEntireSSTableStreamWriter and CassandraOutgoingFile respectively,
there is not any update on particular components of a SSTable as it counts only
"db" file to be there. That introduces this bug:
{code:java}
Mode: NORMAL
Rebuild 2c0b43f0-735d-11ea-9346-fb0ffe238736
/127.0.0.2 Sending 19 files, 27664559 bytes total. Already sent 133 files,
27664559 bytes total
/tmp/dtests15682026295742741219/node2/data/distributed_test_keyspace/cf-196b3...
....
{code}
Basically, number of files to be sent is lower than files sent.
The straightforward fix here is to distinguish when we are streaming entire
sstables and in that case include all manifest files into computation.
This issue relates to https://issues.apache.org/jira/browse/CASSANDRA-15657
because the resolution whether we stream entirely or not is got from a method
which is performance sensitive and computed every time. Once CASSANDRA-15657
(hence CASSANDRA-14586) is done, this ticket can be worked on.
branch with fix is here:
[https://github.com/smiklosovic/cassandra/tree/CASSANDRA-15694]
was:
There is a bug in the current code as if we are streaming entire SSTables via
CassandraEntireSSTableStreamWriter and CassandraOutgoingFile respectively,
there is not any update on particular components of a SSTable as it counts only
"db" file to be there. That introduces this bug:
{code:java}
Mode: NORMAL
Rebuild 2c0b43f0-735d-11ea-9346-fb0ffe238736
/127.0.0.2 Sending 19 files, 27664559 bytes total. Already sent 133 files,
27664559 bytes total
/tmp/dtests15682026295742741219/node2/data/distributed_test_keyspace/cf-196b3...
....
{code}
Basically, number of files to be sent is lower than files sent.
The straightforward fix here is to distinguish when we are streaming entire
sstables and in that case include all manifest files into computation.
This issue relates to https://issues.apache.org/jira/browse/CASSANDRA-15657
because the resolution whether we stream entirely or not is got from a method
which is performance sensitive and computed every time. Once CASSANDRA-15657
(hence CASSANDRA-14586) is done, this ticket can be worked on.
> Statistics upon streaming of entire SSTables in Netstats is wrong
> -----------------------------------------------------------------
>
> Key: CASSANDRA-15694
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15694
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Stefan Miklosovic
> Priority: Normal
>
> There is a bug in the current code as if we are streaming entire SSTables via
> CassandraEntireSSTableStreamWriter and CassandraOutgoingFile respectively,
> there is not any update on particular components of a SSTable as it counts
> only "db" file to be there. That introduces this bug:
>
> {code:java}
> Mode: NORMAL
> Rebuild 2c0b43f0-735d-11ea-9346-fb0ffe238736
> /127.0.0.2 Sending 19 files, 27664559 bytes total. Already sent 133
> files, 27664559 bytes total
>
> /tmp/dtests15682026295742741219/node2/data/distributed_test_keyspace/cf-196b3...
> ....
> {code}
> Basically, number of files to be sent is lower than files sent.
>
> The straightforward fix here is to distinguish when we are streaming entire
> sstables and in that case include all manifest files into computation.
>
> This issue relates to https://issues.apache.org/jira/browse/CASSANDRA-15657
> because the resolution whether we stream entirely or not is got from a method
> which is performance sensitive and computed every time. Once CASSANDRA-15657
> (hence CASSANDRA-14586) is done, this ticket can be worked on.
>
> branch with fix is here:
> [https://github.com/smiklosovic/cassandra/tree/CASSANDRA-15694]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
