[
https://issues.apache.org/jira/browse/CASSANDRA-15674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15674:
------------------------------------
Status: Changes Suggested (was: Review In Progress)
Thanks [~dcapwell]. The primary question I had is why you chose the hooks that
were added vs using the existing onCommit/onAbort API with a delegate or
sub-class implementation used only for IndexSummaryRedistribution. On the
surface that would limit the scope of the change but may actually be more
invasive? Anyways, wanted to get your input and maybe [~benedict]'s as well as
the original API author.
Otherwise, my other comments are all minor:
* Pending counter: can you say a bit more about how you would see an operator
using this metric?
* consider renaming Listener#onPreSample to Listener#beforeResample
* The 4-arity version of the IndexSummaryRedistribution constructor should be
marked @VisibleForTest (and maybe the Listener too? — or at least some comment
that for now it only exists for tests)
* DiskSpaceMetricsTest: Is the TODO on L125 still valid or can it be removed?
Looks like the latter
> liveDiskSpaceUsed and totalDiskSpaceUsed get corrupted if
> IndexSummaryRedistribution gets interrupted
> -----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15674
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15674
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction, Observability/Metrics
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> IndexSummaryRedistribution is a compaction task and as such extends Holder
> and supports cancelation by throwing a CompactionInterruptedException. The
> issue is that IndexSummaryRedistribution tries to use transactions, but
> mutates the sstable in-place; transaction is unable to roll back.
> This would be fine (only updates summary) if it wasn’t for the fact the task
> attempts to also mutate the two metrics liveDiskSpaceUsed and
> totalDiskSpaceUsed, since these can’t be rolled back any cancelation could
> corrupt these metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
