[
https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084799#comment-17084799
]
Alex Petrov commented on CASSANDRA-15733:
-----------------------------------------
Thank you for the patch; left minor comments on both PRs.
> jvm dtest builder should be provided to the factory and expose state
> --------------------------------------------------------------------
>
> Key: CASSANDRA-15733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15733
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently the builder is rather heavy and creates configs plus call the
> factory with specific fields only, this isn’t that flexible and makes it
> harder to have custom cluster definitions which require additional fields to
> be defined. To solve this we should make the builder be sent to the factory
> and expose the state so the factory can get all the fields it needs, the
> factory should also be in charge of creating the configs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
