[
https://issues.apache.org/jira/browse/CASSANDRA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085622#comment-17085622
]
Berenguer Blasi commented on CASSANDRA-15533:
---------------------------------------------
Hi [~jrwest] I fancied taking a look at this patch and I ended up reviewing
it. Be advised I am ramping up on this codebase. LGTM I think you captured all
the uses of the MergeIterator under the sasi package, I would only remove the
unused imports left behind. My 2cts :)
> Don't allocate unneeded MergeIterator in OnDiskToken#iterator
> --------------------------------------------------------------
>
> Key: CASSANDRA-15533
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15533
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SASI
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 4.0, 4.0-rc
>
>
> When reviewing CASSANDRA-15392 it became apparent that the MergeIterator
> allocated by OnDiskToken#iterator is rarely necessary and so we should avoid
> allocating one when not needed and skip the MergeIterator pool when needed
> because its unlikely to be sized correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
