[ 
https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095224#comment-17095224
 ] 

Yifan Cai commented on CASSANDRASC-22:
--------------------------------------

{quote}Now the definition is generated on the fly at runtime and is based on 
the route annotations and return types of the handlers.
{quote}
Nice! I checked out your branch. Play around with the available endpoints. The 
swagger doc generation works for me. And the openApi json endpoint returns good 
result.

I went through the PR. It looks good to me, except the file 
src/main/resources/docs/index.html seems to be committed by mistake. The docs 
endpoint now works without it.

+1 after removing the index.html file.
{quote}generating the clients in this ticket or in a different one?
{quote}
It is better to be addressed in a separate patch, IMO.

> RESTEasy integration for Cassandra Sidecar
> ------------------------------------------
>
>                 Key: CASSANDRASC-22
>                 URL: https://issues.apache.org/jira/browse/CASSANDRASC-22
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: Rest API
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Normal
>         Attachments: image-2020-04-27-22-59-40-060.png
>
>
> Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This 
> also dynamically generates swagger documentation and adds the swagger UI.
> [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger]
> [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to