[
https://issues.apache.org/jira/browse/CASSANDRA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095972#comment-17095972
]
Jordan West edited comment on CASSANDRA-15533 at 4/30/20, 12:03 AM:
--------------------------------------------------------------------
Thanks for taking a look [~Bereng] [~blerer]. I spoke with [~bdeggleston] and
while this patch works, we'd like to extend it to other cases where allocating
a {{MergeIterator}} is unnecessary besides SASI. That said, we can split that
out in the spirit of getting this closed for 4.0.
was (Author: jrwest):
Thanks for taking a look [~Bereng] [~blerer]. I had spoken with [~bdeggleston]
and while this patch works, we'd like to extend it to other cases where
allocating a {{MergeIterator}} is unnecessary besides SASI. That said, we can
split that out in the spirit of getting this closed for 4.0.
> Don't allocate unneeded MergeIterator in OnDiskToken#iterator
> --------------------------------------------------------------
>
> Key: CASSANDRA-15533
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15533
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SASI
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 4.0, 4.0-rc
>
>
> When reviewing CASSANDRA-15392 it became apparent that the MergeIterator
> allocated by OnDiskToken#iterator is rarely necessary and so we should avoid
> allocating one when not needed and skip the MergeIterator pool when needed
> because its unlikely to be sized correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
