[
https://issues.apache.org/jira/browse/CASSANDRA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099731#comment-17099731
]
Benedict Elliott Smith commented on CASSANDRA-15766:
----------------------------------------------------
Couldn't this be kept a bit more idiomatic with the provision of an object with
a {{toString()}} method that invokes {{id()}} ? We could even have such an
object instantiated once per {{InboundMessageHandler}} and once per
{{BufferPool}} so that this is garbage-free for most cases, and continues to
read like a normal logging call?
I've in the past considered introducing a special interface declaring only
{{toString()}} for declaring these via lambdas for each parameter, which might
be a nice way to do this for {{InboundSink}}.
A secondary API might be to provide method parameter options that accept pairs
of (param, function) so that e.g. {{InboundSink}} can provide (t,
{{Throwable::getMessage)}}, and if we wanted {{InboundMessageHandler}} could
provide {{(this, InboundMessageHandler::id)}}
> NoSpamLogger arguments building objects on hot paths
> ----------------------------------------------------
>
> Key: CASSANDRA-15766
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15766
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
> Fix For: 4.0-rc
>
>
> NoSpamLogger is used in hot logging paths to prevent logs being overrun. For
> that to be most effective the arguments to the logger need to be cheap to
> construct. During the internode messaging refactor CASSANDRA-15066,
> performance changes to BufferPool for CASSANDRA-14416
> were accidentally reverted in the merge up from 3.11.
> Reviewing other uses since, it looks like there are a few places where the
> arguments require some form of String building.
> org.apache.cassandra.net.InboundSink#accept
> org.apache.cassandra.net.InboundMessageHandler#processCorruptFrame
> org.apache.cassandra.net.InboundMessageHandler.LargeMessage#deserialize
> org.apache.cassandra.net.OutboundConnection#onOverloaded
> org.apache.cassandra.utils.memory.BufferPool.GlobalPool#allocateMoreChunks
> Formatting arguments should either be precomputed, or if expensive they
> should be computed after the decision on whether to noSpamLog has been made.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
