[
https://issues.apache.org/jira/browse/CASSANDRA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099856#comment-17099856
]
Dean Z commented on CASSANDRA-15636:
------------------------------------
Hi [~djoshi], Seems like a good ticket for starters, let me take this one.
I do have a question about this ticket. What did you meant by "versioned
constants"? I assume you meant the we shall be able to get the protocol version
from the name of the constants' names. But as I see the constants can be
applied to either all versions or versions of a certain range like higher than
v5. How do you name that?
> Refactor protocol related code to eliminate magic numbers
> ---------------------------------------------------------
>
> Key: CASSANDRA-15636
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15636
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
> Reporter: Dinesh Joshi
> Priority: Low
>
> Parts of Cassandra's codebase has protocol related magic numbers. It makes
> the code hard to understand. We should refactor the code to remove magic
> numbers and instead replace them with versioned constants. This will help
> make the code clearer. Example:
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/ErrorMessage.java#L288
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
