[ https://issues.apache.org/jira/browse/CASSANDRA-15798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan West updated CASSANDRA-15798: ------------------------------------ Since Version: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/66eae58cd4f53c03ca5ab6b520aa490f7f61a59c Resolution: Fixed Status: Resolved (was: Ready to Commit) Thanks [~dcapwell]. Committed as 66eae58cd4f53c03ca5ab6b520aa490f7f61a59c. > Only calculate 1.0 + dynamicBadnessThreshold once per loop in > DynamicEndpointSnitch > ----------------------------------------------------------------------------------- > > Key: CASSANDRA-15798 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15798 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode > Reporter: Jordan West > Assignee: Jordan West > Priority: Normal > Fix For: 4.0-beta > > > The change to make dynamicBadnessThreshold volatile and mutable in > https://issues.apache.org/jira/browse/CASSANDRA-12179 could have minor > implications for the performance of this code: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java#L216. > Its better to calculate this once before the loop starts, which has the > added benefit that the value is stable throughout the calculation as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org