[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126135#comment-17126135
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 6/4/20, 6:36 PM:
--------------------------------------------------------------------------
*UPDATE:*
- the failing unit test is a flakey test. The configuration is properly loaded
so it is not caused by this patch.
- small issue with Auth_test.py was fixed.
- the rest of the failing unit tests are related to current failures we already
see on trunk. Some of them are already fixed in the newer commits. Rebase and
run new CI now to confirm the latest status.
was (Author: e.dimitrova):
*UPDATE:*
- the unit test is a flakey test. The configuration is properly loaded so it is
not caused by this patch.
- small issue with Auth_test.py was fixed.
- the rest of the failing unit tests are related to current failures we already
see on trunk. Some of them are already fixed in the newer commits. Rebase and
run new CI now to confirm the latest status.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
