[
https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126972#comment-17126972
]
Alex Petrov commented on CASSANDRA-15733:
-----------------------------------------
Sorry for the delay. +1, and thank you for the patch.
Committed to 2.2 with [4fef917f985ea13ea46f68aae00645cb3592ffcf
|https://github.com/apache/cassandra/commit/4fef917f985ea13ea46f68aae00645cb3592ffcf],
and merged up to
[3.0|https://github.com/apache/cassandra/commit/880b07c2e63f6e1dea92995a1baa14707e3c2e5e],
[3.11|https://github.com/apache/cassandra/commit/04b00498312c2627bd180485565fbd1b18e1fbc3],
and
[trunk|https://github.com/apache/cassandra/commit/7bbc97e5835b64c49fd418581f5a45429c1806b1].
> jvm dtest builder should be provided to the factory and expose state
> --------------------------------------------------------------------
>
> Key: CASSANDRA-15733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15733
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently the builder is rather heavy and creates configs plus call the
> factory with specific fields only, this isn’t that flexible and makes it
> harder to have custom cluster definitions which require additional fields to
> be defined. To solve this we should make the builder be sent to the factory
> and expose the state so the factory can get all the fields it needs, the
> factory should also be in charge of creating the configs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
