[ https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132545#comment-17132545 ]
Caleb Rackliffe commented on CASSANDRA-14888: --------------------------------------------- [~stillalex] I think there's a [minor typo|https://github.com/apache/cassandra/compare/trunk...stillalex:CASSANDRA-14888#diff-8f3132f0fa1e03f77fd29bc9b8163fe3R65] in {{KeyspaceMetricsTest#testMetricsCleanupOnDrop()}}, but otherwise things look good so far. (One other minor nit...you probably don't need the JavaDoc comment for {{ReleasableMetric#release()}}, unless there's something more substantial we need to say there.) > Several mbeans are not unregistered when dropping a keyspace and table > ---------------------------------------------------------------------- > > Key: CASSANDRA-14888 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14888 > Project: Cassandra > Issue Type: Bug > Components: Observability/Metrics > Reporter: Ariel Weisberg > Assignee: Alex Deparvu > Priority: Urgent > Labels: patch-available > Fix For: 4.0-beta > > Attachments: CASSANDRA-14888.patch > > > CasCommit, CasPrepare, CasPropose, ReadRepairRequests, > ShortReadProtectionRequests, AntiCompactionTime, BytesValidated, > PartitionsValidated, RepairPrepareTime, RepairSyncTime, > RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime, > WriteFailedIdealCL > Basically for 3 years people haven't known what they are doing because the > entire thing is kind of obscure. Fix it and also add a dtest that detects if > any mbeans are left behind after dropping a table and keyspace. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org