[
https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132545#comment-17132545
]
Caleb Rackliffe edited comment on CASSANDRA-14888 at 6/10/20, 6:29 PM:
-----------------------------------------------------------------------
[~stillalex] Two minor things:
1.) I think there's a [minor
typo|https://github.com/apache/cassandra/compare/trunk...stillalex:CASSANDRA-14888#diff-8f3132f0fa1e03f77fd29bc9b8163fe3R65]
in {{KeyspaceMetricsTest#testMetricsCleanupOnDrop()}}.
2.) You probably don't need the JavaDoc comment for
{{ReleasableMetric#release()}}, unless there's something more substantial we
need to say there.
Just heads up...there also may have been an issue (which is now resolved) w/
compiling trunk at the time you rebased.
Do you mind creating a quick PR so we can discuss the patch inline?
was (Author: maedhroz):
[~stillalex] Two minor things:
1.) I think there's a [minor
typo|https://github.com/apache/cassandra/compare/trunk...stillalex:CASSANDRA-14888#diff-8f3132f0fa1e03f77fd29bc9b8163fe3R65]
in {{KeyspaceMetricsTest#testMetricsCleanupOnDrop()}}.
2.) You probably don't need the JavaDoc comment for
{{ReleasableMetric#release()}}, unless there's something more substantial we
need to say there.
Just heads up...there also may have been an issue (which is now resolved) w/
compiling trunk at the time you rebased.
> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-14888
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
> Reporter: Ariel Weisberg
> Assignee: Alex Deparvu
> Priority: Urgent
> Labels: patch-available
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14888.patch
>
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests,
> ShortReadProtectionRequests, AntiCompactionTime, BytesValidated,
> PartitionsValidated, RepairPrepareTime, RepairSyncTime,
> RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime,
> WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the
> entire thing is kind of obscure. Fix it and also add a dtest that detects if
> any mbeans are left behind after dropping a table and keyspace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
