[
https://issues.apache.org/jira/browse/CASSANDRA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137860#comment-17137860
]
Ekaterina Dimitrova edited comment on CASSANDRA-15877 at 6/16/20, 7:11 PM:
---------------------------------------------------------------------------
Thank you for the review [~kornelpal]!
???? After the change from random tokens to splits,
TokenAllocatorDiagnostics.randomTokensGenerated does not seem to be used
anymore. Could you please consider removing it, if not needed.????
I think actually I should create new method probably for an event to be
published. I will check what is needed a bit later or Thursday (off tomorrow).
Good catch!
???? I've noticed that you added a new NoReplicationTokenAllocatorTest.failed
field with assertions, but it does not seem to be set to true anywhere. Could
you please check whether it is needed.????
I think this assertion is actually not needed anymore
was (Author: e.dimitrova):
Thank you for the review [~kornelpal]!
?? After the change from random tokens to splits,
TokenAllocatorDiagnostics.randomTokensGenerated does not seem to be used
anymore. Could you please consider removing it, if not needed.??
I think actually I should create new method probably for an event to be
published. I will check what is needed a bit later or Thursday (off tomorrow).
Good catch!
?? I've noticed that you added a new NoReplicationTokenAllocatorTest.failed
field with assertions, but it does not seem to be set to true anywhere. Could
you please check whether it is needed.??
I think this assertion is actually not needed anymore
> Followup on CASSANDRA-15600
> ---------------------------
>
> Key: CASSANDRA-15877
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15877
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Virtual Nodes
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
> Attachments: Screen Shot 2020-06-12 at 3.21.18 PM.png
>
>
> As part of CASSANDRA-15600 generateSplits method replaced the
> generateRandomTokens for NoReplicationAwareTokenAllocator. generateSplits
> should be used also in ReplicationAwareTokenAllocator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
