[
https://issues.apache.org/jira/browse/CASSANDRA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143272#comment-17143272
]
Caleb Rackliffe edited comment on CASSANDRA-15852 at 6/23/20, 8:23 PM:
-----------------------------------------------------------------------
Other than agreeing w/ [~dcapwell] about the intelligibility of the exception
(I might go so far as to make an error message part of the {{SessionInfo}},
although that class is currently immutable), the only other thing is that the
{{throw e}} on {{StreamSession:700}} seems unnecessary.
Assuming those are resolved, LGTM
was (Author: maedhroz):
Other than agreeing w/ [~dcapwell] about the intelligibility of the exception
(I might go so far as to make an error message part of the {{StreamState}} in
general), the only other thing is that the {{throw e}} on {{StreamSession:700}}
seems unnecessary.
Assuming those are resolved, LGTM
> Handle errors in StreamSession#prepare
> --------------------------------------
>
> Key: CASSANDRA-15852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15852
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-beta
>
>
> Since CASSANDRA-12229 we don't handle errors in {{StreamSession#prepare}} -
> this makes a stream initiator hang forever if an error is thrown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
