[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145765#comment-17145765
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-------------------------------------------------
Thank you [~dcapwell]!
Please find my comments below in Italic. I will also make a pass later again
as I admit I was in a hurry to roll it out last night so it can be visible for
people in more time zones before the end of the week to express any bigger
concerns that I can address as this is a beta blocker.
* Config. otc_coalescing_window_us_default was not renamed but the other otc*
configs were. --> _will be corrected_
* block_for_peers_timeout_in_secs and block_for_peers_in_remote_dcs are
exposed in yaml, the comment says "No need of unit conversion as this parameter
is not exposed in the yaml file", can you explain why this comment? --> _it is
not exposed in the yaml for the users so default value and unit is used as per
the Config class setup_
* in database descriptor I see you use toString to compare, why not convert to
the expected unit --> _I was testing and forgot to correct it, will make a pass
to ensure it is corrected everywhere, thanks!_
* we should add docs for Replaces and ReplacesList (also calling out that you
shouldn't use ReplacesList directly) --> _noted_
* for the new types, would be good to have a property test which validates that
{code:java}
type(value, unit).equals(type.parse(type(value, unit).toString())){code}
--> _noted_
* LoadOldYAMLBackwardCompatibilityTest and ParseAndConvertUnitsTest look to be
copy/paste. junit supports inheritance so could remove the copy based by having
LoadOldYAMLBackwardCompatibilityTest extend ParseAndConvertUnitsTest but use
the other config --> _will definitely take care of that, left over from the
previous version, apologize_
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
