[
https://issues.apache.org/jira/browse/CASSANDRA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149071#comment-17149071
]
ZhaoYang edited comment on CASSANDRA-15900 at 7/1/20, 7:39 AM:
---------------------------------------------------------------
rebased and submit another round of ci:
[j8|https://circleci.com/workflow-run/cdf55335-c876-450b-8bf9-1d778a2df806] and
[j11|https://circleci.com/workflow-run/2080f225-f689-4243-ad67-288bef608640]
bq. test_restart_node_localhost -
pushed_notifications_test.TestPushedNotifications should have been addressed by
CASSANDRA-15677 a few days ago.
it's failing after rebase...
bq. J11 - readRepairTest -
org.apache.cassandra.distributed.test.SimpleReadWriteTest
bq. J11 - testImportCorrupt - org.apache.cassandra.db.ImportTest
doesn't seem to be related.
was (Author: jasonstack):
rebased and submit another round of ci:
[j8|https://circleci.com/workflow-run/cdf55335-c876-450b-8bf9-1d778a2df806] and
[j11|https://circleci.com/workflow-run/2080f225-f689-4243-ad67-288bef608640]
> Close channel and reduce buffer allocation during entire sstable streaming
> with SSL
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-15900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Streaming and Messaging
> Reporter: ZhaoYang
> Assignee: ZhaoYang
> Priority: Normal
> Fix For: 4.0-beta
>
>
> CASSANDRA-15740 added the ability to stream entire sstable by loading on-disk
> file into user-space off-heap buffer when SSL is enabled, because netty
> doesn't support zero-copy with SSL.
> But there are two issues:
> # file channel is not closed.
> # 1mb batch size is used. 1mb exceeds buffer pool's max allocation size,
> thus it's all allocated outside the pool and will cause large amount of
> allocations.
> [Patch|https://github.com/apache/cassandra/pull/651]:
> # close file channel when the last batch is loaded into off-heap bytebuffer.
> I don't think we need to wait until buffer is flushed by netty.
> # reduce the batch to 64kb which is more buffer pool friendly when streaming
> entire sstable with SSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
