[ 
https://issues.apache.org/jira/browse/CASSANDRA-15851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152943#comment-17152943
 ] 

David Capwell commented on CASSANDRA-15851:
-------------------------------------------

Patches LGTM, +1 to them

The only failing test I see is trunk jvm 8: 
https://app.circleci.com/pipelines/github/krummas/cassandra/451/workflows/bb1125f6-f455-4a0b-863b-e50dc8a03036/jobs/3428/tests.
  testRestartNode[1: provision strategy=OneNetworkInterface] - 
org.apache.cassandra.distributed.test.TopologyChangeTest.  I don't see any JIRA 
for TopologyChangeTest, but saw the test past on jvm 11 so feel its unrelated 
to this patch.

> Add bytebuddy support for in-jvm dtests
> ---------------------------------------
>
>                 Key: CASSANDRA-15851
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15851
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.0
>
>
> Old python dtests support byteman, but that is quite horrible to work with, 
> [bytebuddy|https://bytebuddy.net/#/] is much better, so we should add support 
> for that in the in-jvm dtests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to