[
https://issues.apache.org/jira/browse/CASSANDRA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160897#comment-17160897
]
Caleb Rackliffe commented on CASSANDRA-15766:
---------------------------------------------
Just a quick summary of where we are with the tests...
In the Java 11 tests, it looks like we've hit CASSANDRA-15861 ({{TestRepair::
test_dead_sync_initiator}}). The other 2 failures look like timeouts, something
we could resolve with [a quick
rerun|https://app.circleci.com/pipelines/github/maedhroz/cassandra/63/workflows/69be5c1b-f43e-4632-a146-29d546ab659d].
In the Java 8 tests, the failure in {{TestBootstrap}} has been [seen
elsewhere|https://issues.apache.org/jira/browse/CASSANDRA-15854?focusedCommentId=17142442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17142442],
so is almost certainly unrelated. CASSANDRA-15861 is showing up as well. The
interesting failure is
{{TestDiskBalance::test_disk_balance_after_boundary_change_stcs}}, although I
haven't been able to reproduce a failure locally. Let's see what [a
rerun|https://app.circleci.com/pipelines/github/maedhroz/cassandra/63/workflows/99e45f4b-c7ae-4a46-8fc3-2e2466f833ed]
looks like...
> NoSpamLogger arguments building objects on hot paths
> ----------------------------------------------------
>
> Key: CASSANDRA-15766
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15766
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Jon Meredith
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> NoSpamLogger is used in hot logging paths to prevent logs being overrun. For
> that to be most effective the arguments to the logger need to be cheap to
> construct. During the internode messaging refactor CASSANDRA-15066,
> performance changes to BufferPool for CASSANDRA-14416
> were accidentally reverted in the merge up from 3.11.
> Reviewing other uses since, it looks like there are a few places where the
> arguments require some form of String building.
> org.apache.cassandra.net.InboundSink#accept
> org.apache.cassandra.net.InboundMessageHandler#processCorruptFrame
> org.apache.cassandra.net.InboundMessageHandler.LargeMessage#deserialize
> org.apache.cassandra.net.OutboundConnection#onOverloaded
> org.apache.cassandra.utils.memory.BufferPool.GlobalPool#allocateMoreChunks
> Formatting arguments should either be precomputed, or if expensive they
> should be computed after the decision on whether to noSpamLog has been made.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
