[ 
https://issues.apache.org/jira/browse/CASSANDRA-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163924#comment-17163924
 ] 

Jon Meredith commented on CASSANDRA-15973:
------------------------------------------

+1 - looks good to me and I really appreciate the QT test.  With regards to 
removing the dead code findSupportingVersion and isSupportedBy, I checked the 
Cassandra & Python Dtest and did a quick search of GitHub itself and couldn't 
find anything. Now all we need is a committer.

> Upgrade of custom 3.0 version fails with custom 4.0 caused by version parsing 
> logic
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15973
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15973
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> In 3.0 and earlier, custom versions could have an extra digit and could have 
> multiple pre release tags separated by -, after upgrading to 4.0 these custom 
> versions no longer are allowed and fail different parts of the code, any 
> place which now uses CassandraVersion.
> The issue is that version was just a String before, so the only parsing rules 
> were controlled by the client, now CassandraVersion is used which is more 
> restrictive.
> To help out, we should allow a "hot fix" digit, and preRelease should allow 
> multiple -



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to