Author: jbellis
Date: Mon May 23 19:43:53 2011
New Revision: 1126683
URL: http://svn.apache.org/viewvc?rev=1126683&view=rev
Log:
remove no-op HHOM.renameHints
patch by Nicholas Telford; reviewed by jbellis for CASSANADRA-2693
Modified:
cassandra/branches/cassandra-0.7/CHANGES.txt
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/HintedHandOffManager.java
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/DropKeyspace.java
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/RenameKeyspace.java
Modified: cassandra/branches/cassandra-0.7/CHANGES.txt
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.7/CHANGES.txt?rev=1126683&r1=1126682&r2=1126683&view=diff
==============================================================================
--- cassandra/branches/cassandra-0.7/CHANGES.txt (original)
+++ cassandra/branches/cassandra-0.7/CHANGES.txt Mon May 23 19:43:53 2011
@@ -7,6 +7,7 @@
* fix IntegerType.getString with direct buffers (CASSANDRA-2684)
* avoid replaying hints to dropped columnfamilies (CASSANDRA-2685)
* add placeholders for missing rows in range query pseudo-RR (CASSANDRA-2680)
+ * remove no-op HHOM.renameHints (CASSANDRA-2693)
0.7.6
Modified:
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/HintedHandOffManager.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/HintedHandOffManager.java?rev=1126683&r1=1126682&r2=1126683&view=diff
==============================================================================
---
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/HintedHandOffManager.java
(original)
+++
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/HintedHandOffManager.java
Mon May 23 19:43:53 2011
@@ -378,37 +378,6 @@ public class HintedHandOffManager implem
rowsReplayed, endpoint));
}
- /** called when a keyspace is dropped or rename. newTable==null in the
case of a drop. */
- public static void renameHints(String oldTable, String newTable) throws
IOException
- {
- DecoratedKey oldTableKey =
StorageService.getPartitioner().decorateKey(ByteBufferUtil.bytes(oldTable));
- // we're basically going to fetch, drop and add the scf for the old
and new table. we need to do it piecemeal
- // though since there could be GB of data.
- ColumnFamilyStore hintStore =
Table.open(Table.SYSTEM_TABLE).getColumnFamilyStore(HINTS_CF);
- ByteBuffer startCol = ByteBufferUtil.EMPTY_BYTE_BUFFER;
- long now = System.currentTimeMillis();
- while (true)
- {
- QueryFilter filter = QueryFilter.getSliceFilter(oldTableKey, new
QueryPath(HINTS_CF), startCol, ByteBufferUtil.EMPTY_BYTE_BUFFER, false,
PAGE_SIZE);
- ColumnFamily cf =
ColumnFamilyStore.removeDeleted(hintStore.getColumnFamily(filter),
Integer.MAX_VALUE);
- if (pagingFinished(cf, startCol))
- break;
- if (newTable != null)
- {
- RowMutation insert = new RowMutation(Table.SYSTEM_TABLE,
ByteBufferUtil.bytes(newTable));
- insert.add(cf);
- insert.apply();
- }
- RowMutation drop = new RowMutation(Table.SYSTEM_TABLE,
oldTableKey.key);
- for (ByteBuffer key : cf.getColumnNames())
- {
- drop.delete(new QueryPath(HINTS_CF, key), now);
- startCol = key;
- }
- drop.apply();
- }
- }
-
/*
* This method is used to deliver hints to a particular endpoint.
* When we learn that some endpoint is back up we deliver the data
Modified:
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/DropKeyspace.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/DropKeyspace.java?rev=1126683&r1=1126682&r2=1126683&view=diff
==============================================================================
---
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/DropKeyspace.java
(original)
+++
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/DropKeyspace.java
Mon May 23 19:43:53 2011
@@ -81,12 +81,6 @@ public class DropKeyspace extends Migrat
assert table != null;
// reset defs.
DatabaseDescriptor.clearTableDefinition(ksm, newVersion);
-
- if (!clientMode)
- {
- // clear up any local hinted data for this keyspace.
- HintedHandOffManager.renameHints(name, null);
- }
}
finally
{
Modified:
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/RenameKeyspace.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/RenameKeyspace.java?rev=1126683&r1=1126682&r2=1126683&view=diff
==============================================================================
---
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/RenameKeyspace.java
(original)
+++
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/migration/RenameKeyspace.java
Mon May 23 19:43:53 2011
@@ -110,7 +110,6 @@ public class RenameKeyspace extends Migr
{
Table.clear(oldKsm.name);
Table.open(newName);
- HintedHandOffManager.renameHints(oldName, newName);
}
}
