[ 
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170478#comment-17170478
 ] 

Jon Meredith commented on CASSANDRA-15981:
------------------------------------------

LGTM

I reproduced the SEGV on my laptop against a commit I know fails (

43c19878e38fbe260f9e6143aa43836e85cf2f44) then cherry-picked the patch on top 
and ran 140 iterations without failure.
 
Checked the process arguments

Under J11 - you can see {{-CMSClassUnloadingEnabled}}

{code}
-Dstorage-config=<path>/test/conf -Djava.awt.headless=true 
-javaagent:<path>/lib/jamm-0.3.2.jar -ea -Djava.io.tmpdir=<path> 
-Dcassandra.debugrefcount=true -Xss256k -XX:SoftRefLRUPolicyMSPerMB=0 
-Dcassandra.memtable_row_overhead_computation_step=100 
-Dcassandra.test.use_prepared=true -Dcassandra.test.offsetseed=0 
-Dcassandra.test.sstableformatdevelopment=true 
-Djava.security.egd=file:/dev/urandom -Dcassandra.testtag= 
-Dcassandra.keepBriefBrief=true -Dcassandra.strict.runtime.checks=true 
-Djdk.attach.allowAttachSelf=true -XX:+UseConcMarkSweepGC 
-XX:+CMSParallelRemarkEnabled -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=1 
-XX:CMSInitiatingOccupancyFraction=75 -XX:+UseCMSInitiatingOccupancyOnly 
-XX:CMSWaitDuration=10000 -XX:+CMSParallelInitialMarkEnabled 
-XX:+CMSEdenChunksRecordAlways --add-exports 
java.base/jdk.internal.misc=ALL-UNNAMED --add-exports 
java.base/jdk.internal.ref=ALL-UNNAMED --add-exports 
java.base/sun.nio.ch=ALL-UNNAMED --add-exports 
java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED --add-exports 
java.rmi/sun.rmi.registry=ALL-UNNAMED --add-exports 
java.rmi/sun.rmi.server=ALL-UNNAMED --add-exports java.sql/java.sql=ALL-UNNAMED 
--add-opens java.base/java.lang.module=ALL-UNNAMED --add-opens 
java.base/java.net=ALL-UNNAMED --add-opens 
java.base/jdk.internal.loader=ALL-UNNAMED --add-opens 
java.base/jdk.internal.ref=ALL-UNNAMED --add-opens 
java.base/jdk.internal.reflect=ALL-UNNAMED --add-opens 
java.base/jdk.internal.math=ALL-UNNAMED --add-opens 
java.base/jdk.internal.module=ALL-UNNAMED --add-opens 
java.base/jdk.internal.util.jar=ALL-UNNAMED --add-opens 
jdk.management/com.sun.management.internal=ALL-UNNAMED -DQT_SHRINKS=0 
-XX:-CMSClassUnloadingEnabled 
-Dlegacy-sstable-root=<path>/test/data/legacy-sstables 
-Dinvalid-legacy-sstable-root=<path>/test/data/invalid-legacy-sstables 
-Dcassandra.ring_delay_ms=1000 -Dcassandra.tolerate_sstable_size=true 
-Dcassandra.config.loader=org.apache.cassandra.OffsetAwareConfigurationLoader 
-Dcassandra.skip_sync=true -Xmx1024m
{code}

Under J8 - and has {{-XX:MaxMetaspaceExpansion=64M -XX:MaxMetaspaceSize=512M 
-XX:MetaspaceSize=128M}}

{code}
-Dstorage-config=<path>/test/conf -Djava.awt.headless=true 
-javaagent:<path>/lib/jamm-0.3.2.jar -ea -Djava.io.tmpdir=<path> 
-Dcassandra.debugrefcount=true -Xss256k -XX:SoftRefLRUPolicyMSPerMB=0 
-Dcassandra.memtable_row_overhead_computation_step=100 
-Dcassandra.test.use_prepared=true -Dcassandra.test.offsetseed=0 
-Dcassandra.test.sstableformatdevelopment=true 
-Djava.security.egd=file:/dev/urandom -Dcassandra.testtag= 
-Dcassandra.keepBriefBrief=true -Dcassandra.strict.runtime.checks=true 
-DQT_SHRINKS=0 -XX:MaxMetaspaceExpansion=64M -XX:MaxMetaspaceSize=512M 
-XX:MetaspaceSize=128M -Dlegacy-sstable-root=<path>/test/data/legacy-sstables 
-Dinvalid-legacy-sstable-root=<path>/test/data/invalid-legacy-sstables 
-Dcassandra.ring_delay_ms=1000 -Dcassandra.tolerate_sstable_size=true 
-Dcassandra.config.loader=org.apache.cassandra.OffsetAwareConfigurationLoader 
-Dcassandra.skip_sync=true -Xmx1024m
{code}

> jvm-dtests crash on java 11
> ---------------------------
>
>                 Key: CASSANDRA-15981
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the 
> JVM to crash.  Since jvm-dtests rely on class loaders and unloading, this 
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally. 
> Please note the time in the report does not reflect the time until the VM 
> exit.
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.util.Vector.forEach(Vector.java:1387)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.util.Vector.forEach(Vector.java:1387)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.lang.Thread.run(Thread.java:834)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to