[
https://issues.apache.org/jira/browse/CASSANDRA-15788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176766#comment-17176766
]
Michael Semb Wever commented on CASSANDRA-15788:
------------------------------------------------
Review comments:
- two small code-stye corrections (comments
[here|https://github.com/apache/cassandra/commit/c90295e87558d0a1ca03c2000b1ee7ba015d638a])
- "I wasn't sure what CachingBench was exactly" <-- me neither. Would have
[thought|https://the-asf.slack.com/archives/CK23JSY2K/p1597264448003700] they
were for {{test/microbench/}}, though there are junit not jmh annotated.
> Add tests to cover CacheMetrics
> -------------------------------
>
> Key: CASSANDRA-15788
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15788
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Normal
>
> {{CacheMetrics}} and {{ChunkCacheMetrics}} do not have unit tests covering
> them. {{CachingBench}} seems to provide some coverage but those tests (which
> don't appear to run as part of the standard run of unit tests) are failing
> and do not assert against all defined metrics, nor do they seem to assert
> code in {{InstrumentingCache}} which also incremented metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
