[
https://issues.apache.org/jira/browse/CASSANDRA-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177109#comment-17177109
]
Sylvain Lebresne commented on CASSANDRA-13994:
----------------------------------------------
Available again so did a review pass on the last version.
And that last version looks good to me. I just gathered a few last nits/minor
suggestions in [this
commit|https://github.com/pcmanus/cassandra/commits/C-13994-review]. Which is
mostly cleaning a few minor things and updating/adding comments. The only 2
real 'code changes' there are:
* in {{CassandraIndex#indexCfsMetadata}}, the leftover special case for keys
index felt more cleanly handled now by overriding the
{{CassandraIndexFunctions#addIndexClusteringColumns}} method, which this commit
does.
* we were checking/throwing for unsupported flags both in {{TableMetadata}}
ctor and in {{SchemaKeyspace#fetchTable}}, and this with different messages,
but the latter calls the former in all cases, so I simplified a bit keeping
only the {{TableMetadata}} ctor case.
But those are all minor suggestions so whether you keep them or not, +1 from me
(assuming CI is still clean on this obviously).
> Remove dead compact storage code before 4.0 release
> ---------------------------------------------------
>
> Key: CASSANDRA-13994
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13994
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
> Reporter: Alex Petrov
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-beta
>
>
> 4.0 comes without thrift (after [CASSANDRA-11115]) and COMPACT STORAGE (after
> [CASSANDRA-10857]), and since Compact Storage flags are now disabled, all of
> the related functionality is useless.
> There are still some things to consider:
> 1. One of the system tables (built indexes) was compact. For now, we just
> added {{value}} column to it to make sure it's backwards-compatible, but we
> might want to make sure it's just a "normal" table and doesn't have redundant
> columns.
> 2. Compact Tables were building indexes in {{KEYS}} mode. Removing it is
> trivial, but this would mean that all built indexes will be defunct. We could
> log a warning for now and ask users to migrate off those for now and
> completely remove it from future releases. It's just a couple of classes
> though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
