[
https://issues.apache.org/jira/browse/CASSANDRA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181445#comment-17181445
]
Caleb Rackliffe commented on CASSANDRA-15909:
---------------------------------------------
I've made a pass at review and left my comments
[inline|https://github.com/spmallette/cassandra/pull/2]. Most of my suggestions
are simple clean-ups and readability enhancements. [~spmallette] When those are
in a good place, I'd be more than willing to kick off the necessary CI runs.
>From the discussion I've seen so far, it doesn't look like we have any
>appetite to do this in 4.0, but I'd really push to remove the "alias" metric
>name factory in {{TableMetrics}}, which is what is making this patch more
>complex than it could be, in our next major release. At minimum, we should use
>CASSANDRA-15821 to indicate very clearly (via {{metrics.rst}}) that both the
>aliases we've added here and the "ColumnFamily"-based paths are going away
>eventually.
> Make Table/Keyspace Metric Names Consistent With Each Other
> -----------------------------------------------------------
>
> Key: CASSANDRA-15909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15909
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Normal
> Fix For: 4.0-beta
>
>
> As part of CASSANDRA-15821 it became apparent that certain metric names found
> in keyspace and tables had different names but were in fact the same metric -
> they are as follows:
> * Table.SyncTime == Keyspace.RepairSyncTime
> * Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows
> * Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime
> * Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize
> * Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize
> * Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize
> * Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize
> Also, client metrics are the only metrics to start with a lower case letter.
> Change those to upper case to match all the other metrics.
> Unifying this naming would help make metrics more consistent as part of
> CASSANDRA-15582
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
