[ 
https://issues.apache.org/jira/browse/CASSANDRA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187885#comment-17187885
 ] 

David Capwell commented on CASSANDRA-16082:
-------------------------------------------

Thanks for the review [~Bereng].  

bq. I dropped some comments in the PR

replied to or fixed all comments.

bq. Also CI looks like it's reporting some error you'd like to look into.

I never run eclipse warnings locally so didn't see this, sorry for asking for a 
review of a build that fails!  Fixed the issue (and will try to add from now on)

> Add a new jmxtool which can dump what JMX objects exist and diff
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-16082
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16082
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/python
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> In order to help validate metric upgrade we first need to know what is new, 
> what was removed, and what was changed.  To help with this, we should add a 
> new jmxtool which can dump the objects from JMX and diff them.
> Once we have this, we can also add a gold list of expected metrics and add 
> tests to validate these metrics don’t change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to