[
https://issues.apache.org/jira/browse/CASSANDRA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186122#comment-17186122
]
Caleb Rackliffe edited comment on CASSANDRA-15909 at 8/31/20, 8:54 PM:
-----------------------------------------------------------------------
I've made changes following my own review suggestions and posted a new, rebased
version of the patch.
[trunk|https://github.com/apache/cassandra/pull/728], [j8
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/99/workflows/72c69ea8-f347-4b00-aed8-bd465f3549ff],
[j11
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/99/workflows/fdac8d5b-2f3d-46f9-8e67-a5a9ed8ab966]
I think the {{ConnectionTest}} failure is a pre-existing issue.
{{TestDiskBalance::test_disk_balance_after_boundary_change_stcs}} is
preexisting as well, but I don't know if we have Jira yet. (UPDATE: created
CASSANDRA-16089)
was (Author: maedhroz):
I've made changes following my own review suggestions and posted a new, rebased
version of the patch.
[trunk|https://github.com/apache/cassandra/pull/728], [j8
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/99/workflows/72c69ea8-f347-4b00-aed8-bd465f3549ff],
[j11
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/99/workflows/fdac8d5b-2f3d-46f9-8e67-a5a9ed8ab966]
I think the {{ConnectionTest}} failure is a pre-existing issue.
{{TestDiskBalance::test_disk_balance_after_boundary_change_stcs}} is
preexisting as well, but I don't know if we have Jira yet.
> Make Table/Keyspace Metric Names Consistent With Each Other
> -----------------------------------------------------------
>
> Key: CASSANDRA-15909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15909
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Stephen Mallette
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> As part of CASSANDRA-15821 it became apparent that certain metric names found
> in keyspace and tables had different names but were in fact the same metric -
> they are as follows:
> * Table.SyncTime == Keyspace.RepairSyncTime
> * Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows
> * Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime
> * Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize
> * Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize
> * Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize
> * Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize
> Also, client metrics are the only metrics to start with a lower case letter.
> Change those to upper case to match all the other metrics.
> Unifying this naming would help make metrics more consistent as part of
> CASSANDRA-15582
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
