[
https://issues.apache.org/jira/browse/CASSANDRA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRA-16113:
----------------------------------
Test and Documentation Plan: unit test, jvm dtest
Status: Patch Available (was: Open)
PR: https://github.com/apache/cassandra/pull/742
Code:
https://github.com/yifan-c/cassandra/tree/CASSANDRA-16113-checks-in-force-repair
Test:
https://app.circleci.com/pipelines/github/yifan-c/cassandra/93/workflows/8e86ef23-b412-4b13-b405-ea68d633122d
Briefly, this patch consolidates duplicated the neighbor node liveness checks
and removal.
* It removes the dead nodes in {{getNeighborsAndRanges()}} for all repair types
when running force repair. (Previously, only incremental repair). The similar
liveness check and removal logic in the {{RepairSession}}'s constructor is
removed.
* {{CommonRange}} is extended to have a new flag, {{hasSkippedReplicas}}, which
indicates if there are dead replicas being removed. It can only be true in
force repair. The flag is add in order to let the normal repair to recognize
the successful repaired ranges.
[~bdeggleston], would you like to review? This patch mainly changes the code
you wrote earlier.
> Consolidate dead nodes check in force repair
> --------------------------------------------
>
> Key: CASSANDRA-16113
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16113
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The check for dead nodes during force repair is duplicated in the normal and
> incremental repair. We could consolidate those 2 checks to make the code more
> dry.
> The check should throw a more meaningful error message to indicate that all
> neighbor nodes are down, instead of "java.lang.IllegalArgumentException:
> Endpoints can not be empty"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
