[
https://issues.apache.org/jira/browse/CASSANDRA-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194544#comment-17194544
]
Caleb Rackliffe edited comment on CASSANDRA-15949 at 9/11/20, 10:06 PM:
------------------------------------------------------------------------
[~dcapwell] So just to summarize, the plan would be...
1.) Remove the synchronization blocks on {{Keyspace}}.
2.) Replace the sync block on {{Keyspace}} in {{open()}} w/ a sync block on the
{{Schema}} singleton. (This ensures most access still results in a cache hit.)
3.) Given it's no longer possible, remove the check in my patch for a null
{{TableMetadataRef}} and the logging accompanying it.
was (Author: maedhroz):
[~dcapwell] So just to summarize, the plan would be...
1.) Remove the synchronization blocks on {{Keyspace}}.
2.) Replace the sync block on {{Keyspace}} in {{open()}} w/ a sync block on the
{{Schema}} singleton.
3.) Given it's no longer possible, remove the check in my patch for a null
{{TableMetadataRef}} and the logging accompanying it.
> NPE thrown while updating speculative execution time if table is removed
> during task execution
> ----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15949
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Jon Meredith
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> CASSANDRA-14338 fixed the scheduling the speculation retry threshold
> calculation, but if the task happens to be scheduled while a table is being
> dropped, it triggers an NPE.
> ERROR 2020-07-14T11:34:55,762 [OptionalTasks:1]
> org.apache.cassandra.service.CassandraDaemon:446 - Exception in thread
> Thread[OptionalTasks:1,5,main]
> java.lang.NullPointerException: null
> at org.apache.cassandra.db.Keyspace.initCf(Keyspace.java:444)
> ~[cassandra-4.0.0.jar:4.0.0]
> at org.apache.cassandra.db.Keyspace.<init>(Keyspace.java:346)
> ~[cassandra-4.0.0.jar:4.0.0]
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:139)
> ~[cassandra-4.0.0.jar:4.0.0]
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:116)
> ~[cassandra-4.0.0.jar:4.0.0]
> at org.apache.cassandra.db.Keyspace$1.apply(Keyspace.java:102)
> ~[cassandra-4.0.0.jar:4.0.0]
> at org.apache.cassandra.db.Keyspace$1.apply(Keyspace.java:99)
> ~[cassandra-4.0.0.jar:4.0.0]
> at
> com.google.common.collect.Iterables$5.lambda$forEach$0(Iterables.java:704)
> ~[guava-27.0-jre.jar:?]
> at
> com.google.common.collect.IndexedImmutableSet.forEach(IndexedImmutableSet.java:45)
> ~[guava-27.0-jre.jar:?]
> at com.google.common.collect.Iterables$5.forEach(Iterables.java:704)
> ~[guava-27.0-jre.jar:?]
> at
> org.apache.cassandra.service.CassandraDaemon.lambda$setup$2(CassandraDaemon.java:412)
> ~[cassandra-4.0.0.jar:4.0.0]
> at
> org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor$UncomplainingRunnable.run(DebuggableScheduledThreadPoolExecutor.java:118)
> [cassandra-4.0.0.jar:4.0.0]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
> [?:?]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
> [?:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> [?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> [?:?]
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> [netty-all-4.1.37.Final.jar:4.1.37.Final]
> at java.lang.Thread.run(Thread.java:834) [?:?]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
