[ 
https://issues.apache.org/jira/browse/CASSANDRA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201712#comment-17201712
 ] 

Yifan Cai commented on CASSANDRA-15457:
---------------------------------------

nit: {{!cis.isEmpty()}} is always true if {{cis}} is not null, according to the 
current implementation. But I think keeping the emptiness check is probably 
more future-proof (in case that the method can return an empty collection)

Since we are using {{StringBuilder}} already, we might just compose the entire 
error message using the builder, and probably also address the {{todo}}.

> Remove bad assert when getting active compactions for an sstable
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-15457
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15457
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Compaction
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 4.x
>
>
> CASSANDRA-14935 added a check that an sstable can only be in a single 
> 'compaction', this is wrong. An sstable can be in a validation and a normal 
> compaction at the same time for example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to