[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205962#comment-17205962 ]
Berenguer Blasi commented on CASSANDRA-15583: --------------------------------------------- All tools flags are being ran and the tool doesn't 'explode' so far sort to speak. Even testing 'non-estoteric' flags imo would be a huge work: test the param, invalid values, corner cases, observe the effects, fix the tool as you go along (I can tell you from what I've seen doing so far 95% of them only account for the happy path)... Nodetool alone is mammoth is that regard. I don't think that middle ground can be done in a timely manner and it could easily be 50% of the overall work left to be done. Finger the air, personal opinion though... > 4.0 quality testing: Tooling, Bundled and First Party > ----------------------------------------------------- > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest/python, Test/unit > Reporter: Josh McKenzie > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0-beta, 4.0-triage > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > *Progress as of Aug 2020* > {{ToolRunner}} has been added enabling us to test tools in java unit tests. > This includes capturing their stdout/err and stdin i.e. Most tools have a > starting unit test testing their cmd line args happy path. Tickets have been > created to improve coverage of those and flagged LHF. Also for those tools > big enough they can't be addressed in a simple ticket such as nodetool, a > placeholder ticket for future improvements has been created as well. Tickets > and status are: > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested. > Dtest also test nodetool as a side effect| > |Cqlsh|(x)|(x) CASSANDRA-16025|(!)| | > |Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| | > |debug-cql|(x)|(x) CASSANDRA-16023|(x)| | > |fqltool|(x)|(/) CASSANDRA-16022|(!)| | > |auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| | > |*Sstable utilities*| | | | | > |sstabledump|(/) CASSANDRA-15991|(/) CASSANDRA-16020|(!)| | > |sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| | > |sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| | > |sstableloader|(x)|(x) CASSANDRA-16017|(!)| | > |sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, > no dedicated test| > |sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| | > |sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in > dtests, no dedicated test| > |sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| | > |sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| | > |sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| | > |sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| | > |sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| | -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org